Allow runtime override of dependencies while also simplifying coding with alias #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
refactor-shell-dependencies
branch
from
647868e
to
72bd207
Compare
alerque
commented
Aug 21, 2024
| @@ -705,7 +713,7 @@ elif [ -n "$2" ]; then | |||
| GIT_DIR=$VCSH_REPO_D/$VCSH_REPO_NAME.git; export GIT_DIR | |||
| [ -d "$GIT_DIR" ] || { help; exit 1; } | |||
| shift 1 | |||
| set -- "@GIT@" "$@" | |||
| set -- "git" "$@" | |||
There was a problem hiding this comment.
I need to test how shells actually handle this, but this one may need to be
Suggested change
| set -- "git" "$@" | |
| set -- "$GIT" "$@" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.