use '?' to work with nullable objects #284
Annotations
10 errors and 11 warnings
Run: Compile, Test, Pack
[xUnit.net 00:00:01.44] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: KnockoutClass, version: 4.3) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:01.60] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: KnockoutClass, version: 2.7) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:01.68] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: Class, version: 1.8) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:01.98] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: Class, version: 2.1) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:02.05] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: Class, version: 4.3) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:02.14] NJsonSchema.CodeGeneration.TypeScript.Tests.TypeScriptDiscriminatorTests.When_parameter_is_abstract_then_generate_union_class [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:02.29] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: Class, version: 2.7) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:02.39] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: KnockoutClass, version: 2.1) [FAIL]
|
Run: Compile, Test, Pack
[xUnit.net 00:00:02.45] NJsonSchema.CodeGeneration.TypeScript.Tests.ClassGenerationTests.Verify_output(style: KnockoutClass, version: 1.8) [FAIL]
|
Run: Compile, Test, Pack
Target "Test" has thrown an exception
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(35,23): warning CS8618: Non-nullable property 'Foo' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(41,23): warning CS8618: Non-nullable property 'Bar' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(73,23): warning CS8618: Non-nullable property 'Person' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
|
Run: Compile, Test, Pack
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(75,24): warning CS8618: Non-nullable property 'Teacher' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
|
Loading