Fix: Skip fetching already locally stored information (#43)

RikudouSage · Feb 8, 2025 · 48b2716 · 48b2716
1 parent a2cd442
commit 48b2716
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 27 deletions.
diff --git a/src/Command/TotalSizeCommand.php b/src/Command/TotalSizeCommand.php
@@ -71,28 +71,17 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $io = new SymfonyStyle($input, $output);
         $games = $this->getGames($input, $output, $this->ownedItemsManager);
 
-        $io->note('Note that if you have a lot of games, this command might take a long time.');
-
         $unit = SizeUnit::tryFrom($input->getOption('unit'));
         if ($unit === null) {
             $io->error("Unsupported unit, please use --help to see list of available units.");
             return Command::FAILURE;
         }
 
         $short = $input->getOption('short');
-        $httpTimeout = $input->getOption('idle-timeout');
         $total = 0;
         foreach ($games as $game) {
             foreach ($game->downloads as $download) {
-                if ($output->isVeryVerbose()) {
-                    $io->comment("[{$game->title}] Downloading file '{$download->name}'");
-                }
-                $size = $this->downloadManager->getFileSize($download, $httpTimeout);
-                if ($size === null && !$short) {
-                    $io->warning("Failed getting size for {$download->name}, the results might be incomplete");
-                    continue;
-                }
-                $total += $size;
+                $total += $download->size;
             }
         }
 
@@ -108,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return Command::SUCCESS;
     }
 
-    private function formatToUnit(int $total, SizeUnit $unit): float
+    private function formatToUnit(float $total, SizeUnit $unit): float
     {
         return match ($unit) {
             SizeUnit::Bytes => $total,

diff --git a/src/Service/DownloadManager.php b/src/Service/DownloadManager.php
@@ -32,20 +32,6 @@ public function getFilename(DownloadDescription $download, int $httpTimeout = 3)
         return urldecode(pathinfo($url, PATHINFO_BASENAME));
     }
 
-    public function getFileSize(DownloadDescription $download, int $httpTimeout = 3): ?int
-    {
-        $url = $this->getRealDownloadUrl($download, $httpTimeout);
-        if (!$url) {
-            return null;
-        }
-
-        $response = $this->httpClient->request(
-            Request::METHOD_HEAD,
-            $url,
-        );
-        return $response->getHeaders()['content-length'][0] ?? null;
-    }
-
     public function download(
         DownloadDescription $download,
         callable $callback,