refactor: remove overcomplicated JS

RinteRface · Mar 14, 2024 · 1d8f4c5 · 1d8f4c5
1 parent b50aed0
commit 1d8f4c5
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 32 deletions.
diff --git a/inst/shinyMobile-1.0.1/dist/shinyMobile.min.css.map b/inst/shinyMobile-1.0.1/dist/shinyMobile.min.css.map
diff --git a/inst/shinyMobile-1.0.1/dist/shinyMobile.min.js b/inst/shinyMobile-1.0.1/dist/shinyMobile.min.js
diff --git a/inst/shinyMobile-1.0.1/dist/shinyMobile.min.js.map b/inst/shinyMobile-1.0.1/dist/shinyMobile.min.js.map
diff --git a/srcjs/bindings/sliderInputBinding.js b/srcjs/bindings/sliderInputBinding.js
@@ -4,7 +4,6 @@ import { getAppInstance } from "../init.js";
 var f7SliderBinding = new Shiny.InputBinding();
 
 $.extend(f7SliderBinding, {
-  app: null,
 
   initialize: function(el) {
 
@@ -47,19 +46,16 @@ $.extend(f7SliderBinding, {
 
   // Given the DOM element for the input, return the value
   getValue: function(el) {
-    this.app = getAppInstance();
     return this.app.range.getValue($(el)[0]);
   },
 
   // see updateF7Slider
   setValue: function(el, value) {
-    this.app = getAppInstance();
     this.app.range.setValue($(el)[0], value);
   },
 
   // see updateF7Slider
   receiveMessage: function(el, data) {
-    this.app = getAppInstance();
     // create a variable to update the range
     var r = this.app.range.get(el.id);
     if (data.hasOwnProperty('min')) {

diff --git a/srcjs/bindings/stepperInputBinding.js b/srcjs/bindings/stepperInputBinding.js
@@ -4,7 +4,6 @@ import { getAppInstance } from "../init.js";
 var f7StepperBinding = new Shiny.InputBinding();
 
 $.extend(f7StepperBinding, {
-  app: null,
 
   initialize: function(el) {
 
@@ -51,31 +50,26 @@ $.extend(f7StepperBinding, {
 
   // Given the DOM element for the input, return the value
   getValue: function(el) {
-    this.app = getAppInstance();
     return this.app.stepper.getValue($(el)[0]);
   },
 
   // see updateF7Stepper
   setValue: function(el, value) {
-    this.app = getAppInstance();
     this.app.stepper.setValue(el, value);
   },
 
   // the 2 methods below are needed by incrementF7Stepper
   // and decrementF7Stepper
   increment: function() {
-    this.app = getAppInstance();
     this.app.stepper.increment();
   },
 
   decrement: function() {
-    this.app = getAppInstance();
     this.app.stepper.decrement();
   },
 
   // see updateF7Stepper
   receiveMessage: function(el, data) {
-    this.app = getAppInstance();
     // create a variable to update the stepper
     var s = this.app.stepper.get($(el));
 
@@ -174,7 +168,6 @@ $.extend(f7StepperBinding, {
 
   subscribe: function(el, callback) {
     $(el).on('stepper:change.f7StepperBinding', function(e) {
-      this.app = getAppInstance();
       // no need to debounce here
       // except if autorepeat is set
       // then we send the value once

diff --git a/srcjs/bindings/virtualListBinding.js b/srcjs/bindings/virtualListBinding.js
@@ -4,7 +4,6 @@ import { getAppInstance } from "../init.js";
 var f7VirtualListBinding = new Shiny.InputBinding();
 
 $.extend(f7VirtualListBinding, {
-  app: null,
 
   // decode html so that images tag are converted to strings
   decodeHTML: function(html) {
@@ -119,7 +118,6 @@ $.extend(f7VirtualListBinding, {
 
   // Given the DOM element for the input, return the value
   getValue: function(el) {
-    this.app = getAppInstance();
     var vl = this.app.virtualList.get($(el)[0]);
     return {
       length: vl.items.length,
@@ -131,7 +129,6 @@ $.extend(f7VirtualListBinding, {
 
   // see updateF7VirtualList
   setValue: function(el, value) {
-    this.app = getAppInstance();
     var vl = this.app.virtualList.get($(el)[0]);
     vl.resetFilter();