Skip to content

Commit

Permalink
remove deprecated args and add f7Toolbar test
Browse files Browse the repository at this point in the history
  • Loading branch information
hypebright committed Mar 20, 2024
1 parent be9d17d commit 8971140
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 0 additions & 2 deletions R/f7-tabs.R
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,6 @@ f7Tabs <- function(..., .items = NULL, id = NULL, swipeable = FALSE, animated =
} else if (style == "toolbar") {
f7Toolbar(
position = "bottom",
hairline = TRUE,
shadow = TRUE,
icons = TRUE,
scrollable = FALSE,
tabItems,
Expand Down
2 changes: 0 additions & 2 deletions R/f7Panel.R
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
#' toolbar = f7Toolbar(
#' position = "bottom",
#' icons = TRUE,
#' hairline = FALSE,
#' shadow = FALSE,
#' f7Link(label = "Link 1", href = "https://www.google.com"),
#' f7Link(label = "Link 2", href = "https://www.google.com")
#' ),
Expand Down
5 changes: 5 additions & 0 deletions tests/testthat/test-f7Toolbar.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
test_that("toolbar works", {
expect_s3_class(f7Toolbar(position = "top"), "shiny.tag")
expect_identical(f7Toolbar(position = "top")$attribs$class, "toolbar toolbar-top")
expect_identical(f7Toolbar(icons = TRUE, position = "top")$attribs$class, "toolbar tabbar tabbar-icons toolbar-top")
})

0 comments on commit 8971140

Please sign in to comment.