Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release patch #261

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Post release patch #261

merged 9 commits into from
Jul 17, 2024

Conversation

hypebright
Copy link
Contributor

@hypebright hypebright commented May 28, 2024


// attach Framework7 to the window object
// allows usage in browser at later stage (e.g. for offline PWA page)
window.Framework7 = Framework7;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DivadNojnarg, as said, I find this ugly 😿. But can't get it to work with export...

@DivadNojnarg
Copy link
Member

shinylive was updated from main since it could not wait.

@hypebright hypebright marked this pull request as ready for review June 4, 2024 09:47
Copy link
Member

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hypebright!

@DivadNojnarg DivadNojnarg merged commit 383e865 into master Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation issue in versions < R4.1 will have error because of \() usage
2 participants