ripme downloading the -mobile.mp4 from redgifs/gfycat

[ANaPhOrAX]

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

• a bug fix (Fix #...)
• a new feature

Description

Please make the ripper download the full quality mp4 from redgifs/gfycat, instead of the the -mobile.mp4. There's a fork of ripme here that does download the correct version. It was linked on another bug report of the mobile mp4 issue, here

Testing

Required verification:

• I've verified that there are no regressions in mvn test (there are no new failures or errors) <--- not sure what this means, sorry
• I've verified that this change works as intended.
  • Downloads all relevant content.
  • Downloads content from multiple pages (as necessary or appropriate). <--- seems to do this for the most part, yes, but it does seem to bug out on certain things the newer version doesn't bug out on
  • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
• I've verified that this change did not break existing functionality (especially in the Ripper I modified).

That fork of ripme does work for the -mobile mp4 issue, but it's as you can see quite a bit older (1.7.97 compared to your 2.0.1), so probably just want to take the bit that works and discard the rest, I guess.

Hope I did this pull request vaguely correctly man, I'm sorry if I messed it up, it's my first time doing this.

[soloturn]

it looks like you wanted to do the pull reqestion towards https://github.com/ripmeapp2/ripme/pulls ... as normally a pul lrequest has only a couple of commits and yours hee a lot. i tried to cherry-pick your commits to ripme2 therefor ...