Refactor/constants #39
Conversation
| hear_config = os.path.join( | ||
| get_package_share_directory("speech"), "config", "hear.yaml" | ||
| ) | ||
| speaker_config = os.path.join( | ||
| get_package_share_directory("speech"), "config", "speaker.yaml" |
There was a problem hiding this comment.
im not getting why are we changing this??
There was a problem hiding this comment.
yaml config has keys with values "REPLACE". parse_ros_config updates such values, using the constants defined in ModuleNames.HRI.value
There was a problem hiding this comment.
lmao, seems like a lot isnt it?
There was a problem hiding this comment.
I would prefer to have all in one place, why should we keep the input name in the config?
There was a problem hiding this comment.
but seems ok either way, this also seems pretty elegant, I dont dislike it
There was a problem hiding this comment.
feel free to close this, just wanted to know why
There was a problem hiding this comment.
I would prefer to have all in one place, why should we keep the input name in the config?
Hmm, so that we know which values to insert / which values are being replaced?
Use cases:
Notes:
frida_interfaceswas not possible: apparently,rosidl_generate_interfacesandament_python_install_packagedon't work in the same CMake project. There are several workarounds but will leave as it is for the moment.