a bit stuck

Roave · Nov 22, 2021 · 698b3b9 · 698b3b9
1 parent fdb22c9
commit 698b3b9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/build-conflicts.php b/build-conflicts.php
@@ -163,6 +163,9 @@ static function (array $components): array {
         Shell\execute('cp', [$sourceComposerJsonPath, $targetComposerJsonPath]);
     };
 
+    /**
+     * @psalm-suppress MixedAssignment
+     */
     $commitComposerJson = static function (string $composerJsonPath, array $addedAdvisories): void {
         $originalHash = Shell\execute(
             'git',
@@ -224,13 +227,14 @@ static function (array $components): array {
     ));
 
     $prevComposerJSONFileData = file_get_contents(__DIR__ . '/build/roave-security-advisories/composer.json');
+
+    /** @var array $prevComposerDecodedData
+     */
     $prevComposerDecodedData  = json_decode($prevComposerJSONFileData, true);
+
+    /** @var array<array-key, string> $oldConflictPackages */
     $oldConflictPackages      = array_keys($prevComposerDecodedData['conflict']);
 
-//    /** @var list<Advisory> $addedAdvisories */
-    /**
-     * @psalm-param $addedAdvisories Advisory
-     */
     $addedAdvisories = [];
     foreach ($getAdvisories() as $advisory) {
         if (in_array($advisory->package->packageName, $oldConflictPackages, true)) {

diff --git a/src/Roave/SecurityAdvisories/Advisory.php b/src/Roave/SecurityAdvisories/Advisory.php
@@ -28,11 +28,13 @@
 /** @psalm-immutable */
 final class Advisory
 {
+    /** @var PackageName  */
     public PackageName $package;
 
     /** @var list<VersionConstraint> */
     private array $branchConstraints;
 
+    /** @var Source */
     public Source $source;
 
     /**

diff --git a/src/Roave/SecurityAdvisories/Source.php b/src/Roave/SecurityAdvisories/Source.php
@@ -9,10 +9,10 @@
 
 final class Source
 {
-    /** @var non-empty-string */
+    /** @var non-empty-string $summary */
     public string $summary;
 
-    /** @var non-empty-string */
+    /** @var non-empty-string $uri */
     public string $uri;
 
     /**