Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for django>=1.7 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nauman3128
Copy link

Hi
Currently this package has no support for django>=1.7 there are some changes that needs to make it working in Django>=1.7. 1st thing in urls.py this line needs to be changed from
from django.conf.urls.defaults import *
to
from django.conf.urls import * or from django.conf.urls import patterns
2nd thing for django>=1.7
"The module django.utils.simplejson will be removed. The standard library provides json which should be used instead."
this line in views.py
import simplejson to import json also changes in code due to this change.

I have make changes in my branch please review that.

@perthvader
Copy link

+1

@Goury
Copy link

Goury commented Oct 20, 2015

So I wonder: is django-locking abandoned?
Cause its not just wont work on new django, its incomplete (yep, some functions just stubs yet without "#TODO" marker.

I are interested to update and maintain this application (already updated for 1.8.4 and completed most of the stubs) yet I will not publish it under current therms but under GNU AGPL v3.

@jtinsky
Copy link

jtinsky commented Oct 26, 2015

Goury, have at it, please post your forked repo here and thanks for your work.

@Goury
Copy link

Goury commented Oct 26, 2015

jtinsky, for now its part of my project under AGPL v3 on https://bitbucket.org/mlug/mlug.ru-django (you can just grab app locking from beta branch).
Ill make separate repo for it and update contributors info a little later (but before merging into master branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants