Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automate-right-to-erasure.md #1004

Merged
merged 8 commits into from
Jan 31, 2025
Merged

Update automate-right-to-erasure.md #1004

merged 8 commits into from
Jan 31, 2025

Conversation

sammygrey
Copy link
Contributor

@sammygrey sammygrey commented Jan 28, 2025

Added tabs for different Python modules needed for Guilded and Discord respectively. Changed DISCORD_BOT_TOKEN and GUILDED_BOT_TOKEN to just BOT_TOKEN for a more universal approach to access token usage. There are different tabs everywhere else for differences between creating a bot for Discord and Guilded, so this feels like an inconsistency.

This inconsistency was brought to my attenting by @bura1414 from this devforum post.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@sammygrey sammygrey requested a review from a team as a code owner January 28, 2025 20:45
@github-actions github-actions bot added the cloud label Jan 28, 2025
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jan 28, 2025
@sammygrey
Copy link
Contributor Author

Not proud of how much I had to fight with GitHub's web editor and md discrepancies for what should have been a very easy change to make.

@aetter
Copy link
Contributor

aetter commented Jan 30, 2025

Hey @sammygrey, this looks great, thanks for sending over. I've added the checks to your initial comment -- need those marked before we can merge. Thanks again!

Copy link
Contributor Author

@sammygrey sammygrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

sammygrey and others added 8 commits January 30, 2025 21:44
Styling change for spacing
Fixed styling more (curse auto-indent). Replaced other sections that use "DISCORD_BOT_TOKEN" or "GUILDED_BOT_TOKEN" to just use "BOT_TOKEN" for better interchangeability.
Fixed spacing for first bash script I changed
Escape for Tabs element was missing
Not happy with how much im fighting with auto-space/tab
Needs me to change 2 to 1 for whatever reason. I'm guessing because this is also in the main branch, whatever you use to display markdown fixes this.
@aetter aetter merged commit 8643073 into Roblox:main Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants