-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automate-right-to-erasure.md #1004
Conversation
Not proud of how much I had to fight with GitHub's web editor and md discrepancies for what should have been a very easy change to make. |
Hey @sammygrey, this looks great, thanks for sending over. I've added the checks to your initial comment -- need those marked before we can merge. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job!
Styling change for spacing
Fixed styling more (curse auto-indent). Replaced other sections that use "DISCORD_BOT_TOKEN" or "GUILDED_BOT_TOKEN" to just use "BOT_TOKEN" for better interchangeability.
Fixed spacing for first bash script I changed
Escape for Tabs element was missing
Not happy with how much im fighting with auto-space/tab
Needs me to change 2 to 1 for whatever reason. I'm guessing because this is also in the main branch, whatever you use to display markdown fixes this.
Added tabs for different Python modules needed for Guilded and Discord respectively. Changed DISCORD_BOT_TOKEN and GUILDED_BOT_TOKEN to just BOT_TOKEN for a more universal approach to access token usage. There are different tabs everywhere else for differences between creating a bot for Discord and Guilded, so this feels like an inconsistency.
This inconsistency was brought to my attenting by @bura1414 from this devforum post.
Checks
By submitting your pull request for review, you agree to the following: