Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mis-attributed game credit #1011

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Correct mis-attributed game credit #1011

merged 1 commit into from
Feb 4, 2025

Conversation

UpliftJoe
Copy link
Contributor

Changes

  • Corrected mis-attribution in screenshot from Adopt Me! to Pet Simulator X!

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@UpliftJoe UpliftJoe requested a review from a team as a code owner February 3, 2025 18:29
@github-actions github-actions bot added the design Changes the Design content label Feb 3, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @UpliftJoe, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@aetter
Copy link
Contributor

aetter commented Feb 3, 2025

Hey @UpliftJoe, thanks a bunch for the PR. Is it fair to say your level of confidence here is high? 😄 I did some digging for images, popped into the game, etc. and still can't definitively say what the screenshot is from given the rate of change (although it definitely doesn't seem to be Adopt Me).

IgnisRBX
IgnisRBX previously approved these changes Feb 3, 2025
@IgnisRBX IgnisRBX dismissed their stale review February 3, 2025 23:10

Further review...

@IgnisRBX
Copy link
Contributor

IgnisRBX commented Feb 3, 2025

Agreed that it's probably "Pet Simulator X", but likely a very old screenshot and the game's UI has changed since then.

@UpliftJoe
Copy link
Contributor Author

Hiya! It's 100% not Adopt Me! I'm almost entirely confident based on conversations and old YouTube videos that it's a rather old version of Pet Simulator X! Couldn't date it for you tho...

I'm sure this could probably be replaced with a more modern example though! Just figured a correct attribution to be worthwhile if the screenshot is remaining as is.

@aetter
Copy link
Contributor

aetter commented Feb 4, 2025

Sold! Really appreciate the PR.

@aetter aetter merged commit 10ce03f into Roblox:main Feb 4, 2025
3 checks passed
@UpliftJoe UpliftJoe deleted the patch-1 branch February 4, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Changes the Design content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants