Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RaycastResult.yaml #1015

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

lack-of-gravity-jack
Copy link
Contributor

Changes

Changed the references from "instance" to BasePart. Referring to the type of the intersected object as "instance" is too generic and may be confusing, since Models and Folders are also instances that some intersected object could have been a child of, but raycasts can only return a reference to the object in of itself and never the parent model. The (poorly named) instance property of RaycastResult can only ever hold a basepart or a terrain cell, and terrain descends from basepart so basepart is accurate and more specific than instance.

Checks

By submitting your pull request for review, you agree to the following:

  • [x ] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • [x ] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • [x ] To the best of my knowledge, all proposed changes are accurate.

@lack-of-gravity-jack lack-of-gravity-jack requested a review from a team as a code owner February 6, 2025 00:13
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Feb 6, 2025
@IgnisRBX IgnisRBX merged commit 0b56613 into Roblox:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants