Add enums for statements (camera mode, camera motion mode, 3D cursor mode) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkimurak
force-pushed
the
enumerize
branch
2 times, most recently
from
d0834dd
to
0ee7196
Compare
kkimurak
commented
Aug 23, 2020
| if (mode==2 || mode==5) view_xyz[2] += 0.01f * dReal(deltay); | ||
| if (mode==CameraMotionMode::MOVE_POSITION_FREELY) view_xyz[2] += 0.01f * dReal(deltay); |
There was a problem hiding this comment.
I'm wondering where mode==5 came from.
cameraMotion() is only called from GLWidget::mouseMoveEvent(QMouseEvent *event), but it only uses 1 , 2 and 4.
mahi97
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or RFC Endorsed by GrSim's Maintainers
little bit related to #27 .
Description of the Change
Those statements flags are treated as
int.adding enum to describe how those statements works makes easier to read code, and also we can write documentation easier.
Alternate Designs
Possible Drawbacks
Verification Process
Release Notes
N/A