Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enums for statements (camera mode, camera motion mode, 3D cursor mode) #123

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

kkimurak
Copy link
Contributor

Issue or RFC Endorsed by GrSim's Maintainers

little bit related to #27 .

Description of the Change

Those statements flags are treated as int.
adding enum to describe how those statements works makes easier to read code, and also we can write documentation easier.

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

N/A

@kkimurak kkimurak force-pushed the enumerize branch 2 times, most recently from d0834dd to 0ee7196 Compare August 23, 2020 13:26
if (mode==2 || mode==5) view_xyz[2] += 0.01f * dReal(deltay);
if (mode==CameraMotionMode::MOVE_POSITION_FREELY) view_xyz[2] += 0.01f * dReal(deltay);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering where mode==5 came from.
cameraMotion() is only called from GLWidget::mouseMoveEvent(QMouseEvent *event), but it only uses 1 , 2 and 4.

@mahi97 mahi97 merged commit 59058ec into RoboCup-SSL:master Sep 2, 2020
@kkimurak kkimurak deleted the enumerize branch September 2, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants