[drake_cmake_installed] Replace broken particles example #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, just sync up with the drake_cmake_installed_apt example. It is not a great demo, but it's what we have.
jwnimmer-tri
force-pushed
the
remove-particle-viz
branch
from
9f6e17f to
882474f
Compare
|
+@BetsyMcPhail for feature review please, or also feel free to delegate. |
BetsyMcPhail
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
CI is happy and I confirmed the sync test includes all the duplicated files.
Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @jwnimmer-tri)
|
Ooops I realized I merged without platform review! I guess it's not required by Reviewable for this repo? |
|
Yeah. Shrug. Since this is mostly just copying some files I think it's okay. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just sync it up with the
drake_cmake_installed_aptexample. It is not a great demo, but it's what we have.Closes #233.
This change is