[rosidl] Ensure *_defs data is added to *_py and *_cc targets #305
Conversation
EricCousineau-TRI
force-pushed
the
feature-defs-with-cc-py
branch
from
06b7496 to
0b754cd
Compare
There was a problem hiding this comment.
+@kunimatsu-tri for review, please!
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @kunimatsu-tri)
|
|
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI and @kunimatsu-tri)
a discussion (no related file):
Working: Certain Anzu tests fail with something like:
File "{runfiles}/bazel_ros2_rules/ros2/tools/dload_shim.py", line 58, in do_dload_shim
os.execv(real_executable_path, argv)
OSError: [Errno 7] Argument list too long
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI and @kunimatsu-tri)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Certain Anzu tests fail with something like:
File "{runfiles}/bazel_ros2_rules/ros2/tools/dload_shim.py", line 58, in do_dload_shim os.execv(real_executable_path, argv) OSError: [Errno 7] Argument list too long
The AMENT_INDEX_PATH environment variable has ~800 duplicate entries for rosidl_generate_ament_index_entry
These should be deduplicated
|
nit Can I ask you to add a corresponding doc string to the data argument? Ditto for all the interface changes. |
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
:( |
EricCousineau-TRI
force-pushed
the
feature-defs-with-cc-py
branch
from
0b754cd to
c6d68aa
Compare
Deduplicate AMENT_PREFIX_PATH
EricCousineau-TRI
force-pushed
the
feature-defs-with-cc-py
branch
from
c6d68aa to
5d6f277
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @kunimatsu-tri)
a discussion (no related file):
Previously, kunimatsu-tri (Kunimatsu Hashimoto) wrote…
:(
Done.
bazel_ros2_rules/ros2/rosidl.bzl line 402 at r1 (raw file):
Previously, kunimatsu-tri (Kunimatsu Hashimoto) wrote…
nit Can I ask you to add a corresponding doc string to the data argument?
Ditto for all the interface changes.
Done.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
:) |
There was a problem hiding this comment.
I confirmed that custom_message_list_test passes locally.
Thanks for this quick fix!
Reviewable status: 2 of 3 files reviewed, all discussions resolved
|
|
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @kunimatsu-tri)
a discussion (no related file):
Previously, kunimatsu-tri (Kunimatsu Hashimoto) wrote…
Build drake_rosin CI failed with the following error:ERROR: /home/runner/.cache/bazel/\_bazel\_runner/d07b19e4bc14c7eead45599d9bb941ba/external/vtk/BUILD.bazel:31:11: Middleman \_middlemen/@vtk\_S\_S\_Cvtkkwiml-cc\_library-compile failed: missing input file '@vtk//:include/vtk-9.1/vtk\_kwiml.h' [136](https://github.com/RobotLocomotion/drake-ros/actions/runs/6661541550/job/18104550754#step:13:137)ERROR: /home/runner/.cache/bazel/\_bazel\_runner/d07b19e4bc14c7eead45599d9bb941ba/external/vtk/BUILD.bazel:31:11: Middleman \_middlemen/@vtk\_S\_S\_Cvtkkwiml-cc\_library-compile failed: missing input file '@vtk//:include/vtk-9.1/vtkkwiml/abi.h' [137](https://github.com/RobotLocomotion/drake-ros/actions/runs/6661541550/job/18104550754#step:13:138)ERROR: /home/runner/.cache/bazel/\_bazel\_runner/d07b19e4bc14c7eead45599d9bb941ba/external/vtk/BUILD.bazel:31:11: Middleman \_middlemen/@vtk\_S\_S\_Cvtkkwiml-cc\_library-compile failed: missing input file '@vtk//:include/vtk-9.1/vtkkwiml/int.h' [138](https://github.com/RobotLocomotion/drake-ros/actions/runs/6661541550/job/18104550754#step:13:139)ERROR: /home/runner/.cache/bazel/\_bazel\_runner/d07b19e4bc14c7eead45599d9bb941ba/external/vtk/BUILD.bazel:31:11: Middleman \_middlemen/@vtk\_S\_S\_Cvtkkwiml-cc\_library-compile failed: 3 input file(s) do not exist
BTW That's because #304 upgraded the Drake pin but did not account for the VTK deprecation warning. The contact_markers_system.cc is doing #include <vtkImageData.h> using Drake's deprecated VTK repository rule, but somehow has not installed libvtk9-dev? However, I do see drake_ros/package.xml has <depend>libvtk9-dev</depend> so I'm not sure why that package apparently isn't installed in CI.
|
Ah, nuts. For now, I'll merge this PR (since testing passed locally) and fix the vtk issue in a separate PR. |
Towards Anzu bugfix
This change is