Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra ; that cause a warning #359

Closed
wants to merge 1 commit into from

Conversation

TomCC7
Copy link

@TomCC7 TomCC7 commented Jul 9, 2024

error message:

--- stderr: drake_ros
/workspace/codes/cc_control_ws/src/drake-ros/drake_ros/viz/scene_markers_system.cc:39:58: error: extra ‘;’ [-Werror=pedantic]
   39 |   DRAKE_NO_COPY_NO_MOVE_NO_ASSIGN(SceneGeometryToMarkers);
      |                                                          ^
      |                                                          -
cc1plus: all warnings being treated as errors

This change is Reviewable

@jwnimmer-tri
Copy link
Contributor

Apologies for the trouble, and thanks for bringing to our attention.

The lack of a semicolon is deprecated in the current Drake nightlies, and the semicolon will be strictly required in a future Drake release. So we need to keep the semicolon there.

Instead, I've filed #360 which hopefully fixes the error. Turning on -Werror=pedantic is aggressively disruptive, so the build should never have done that in the first place.

@jwnimmer-tri
Copy link
Contributor

Closing in lieu of #360. If that PR doesn't actually fix your problem, just let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants