Switch pub/sub serializers away from unique_ptr #374
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran an Anzu full local build+test against this patch and everything passed. +@EricCousineau-TRI for review, please. +@calderpg-tri for general approval or in case you'd like me/someone to do extra testing. |
EricCousineau-TRI
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Some CI errors seem due to upstream breakages, other seems due to discrete\_contact\_solver, so related to #373.
I unfortunately don't have time atm to investigate, and don't want to hold progress on upstream issue.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @calderpg-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards RobotLocomotion/drake#21968.
This contains the same kind of fixes as RobotLocomotion/drake#19369 and RobotLocomotion/drake#22463, plus one additional change (removing the apparently unnecessary
py::wrapper).This change is