Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Target Tree generation and added extra user configurations #89

Merged
merged 8 commits into from
Apr 19, 2024

Conversation

sureshjoshi
Copy link
Member

Pulled from #83 - but there were merge conflicts, and trying to use gh pr ... completely blew up locally. So, pushed the changes to a local branch, and creating a dupe PR.

Added

  • Ignore Lockfiles setting so users can (un)ignore lockfiles when generating targets.
  • Build Files Extension setting for users to specify an extension for BUILD files (i.e. BUILD.pants)
  • A few more helper scripts in the package.json
  • Helper function in configuration.ts that will return a default value for an undefined user setting (matches default value in package.json).

Changed

  • Bumped pants version to latest stable 2.20.0
  • configuration.ts to read new config values.
  • targets-provider.ts's main getChildren() method not returns a PantsTreeItem array of both TargetTreeItems and FolderTreeItems.
  • peek() now supports the Ignore Lockfiles user setting.
  • vscode.open on the BUILD files now support the user-specified Build File Extension setting.

@sureshjoshi sureshjoshi merged commit 884ffff into main Apr 19, 2024
1 check passed
@sureshjoshi sureshjoshi deleted the riebecj-main branch April 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant