-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecs refactor #266
Draft
p-galligan
wants to merge
21
commits into
development
Choose a base branch
from
ecs-refactor
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ecs refactor #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move folders around and initial commit for refactoring.
Adds initial dockerfile and tests
Adds coverage and tox files
Updates requirements files.
updates test and deploy workflow
Removes unnecessary files and updates gitignore
Initial routines outline
Adds placeholder functions and descriptions to transform.py
Adds placeholder SNS routines to transform.py
add placeholder function names to test_transform
Updates readme
Fixes requirements.txt to use Python 3.11
Updates python version in requirements
Linting fixes
Trying tox update to match ursa major
Updates imports for testing
I'm still experiencing major pre-commit issues on my local machine, and I'm not sure why the Py311 environment is failing right now, as I'm not getting any local errors. |
The tests are failing for me locally for two reasons:
IMO both things are fine for now - we're not going to merge this anyway until the application logic and tests are in place. |
Updates gitignore for DS_Store
Deletes unnecessary file
Updates python version
Remove routes
Updates copyright year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR Changes
Create new structure
Adds src and test directories and sets up placeholder logic and functions with docstrings and a main guard method.
Update Dockerfile
Updates Dockerfile to target Python build, uses Python 3.11, set up build stages.
Set up testing infrastructure
Created test_requirements file. Created a tox.ini file. Added a coveragerc file. Set up pre-commit configurations.
Remove Unused Django files
Removes some unused Django files. Updates .gitignore.
Update CI/CD
Updates test and deploy logic in GitHub workflows.
Update documentation
Updates readme based on the Ursa Major's approach.