Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecs refactor #266

Draft
wants to merge 21 commits into
base: development
Choose a base branch
from
Draft

Ecs refactor #266

wants to merge 21 commits into from

Conversation

p-galligan
Copy link
Member

Draft PR Changes

Create new structure

Adds src and test directories and sets up placeholder logic and functions with docstrings and a main guard method.

Update Dockerfile

Updates Dockerfile to target Python build, uses Python 3.11, set up build stages.

Set up testing infrastructure

Created test_requirements file. Created a tox.ini file. Added a coveragerc file. Set up pre-commit configurations.

Remove Unused Django files

Removes some unused Django files. Updates .gitignore.

Update CI/CD

Updates test and deploy logic in GitHub workflows.

Update documentation

Updates readme based on the Ursa Major's approach.

Move folders around and initial commit for refactoring.
Adds initial dockerfile and tests
Adds coverage and tox files
Updates requirements files.
updates test and deploy workflow
Removes unnecessary files and updates gitignore
Initial routines outline
Adds placeholder functions and descriptions to transform.py
Adds placeholder SNS routines to transform.py
add placeholder function names to test_transform
Updates readme
Fixes requirements.txt to use Python 3.11
Updates python version in requirements
Linting fixes
Trying tox update to match ursa major
Updates imports for testing
@p-galligan
Copy link
Member Author

p-galligan commented Jan 29, 2025

I'm still experiencing major pre-commit issues on my local machine, and I'm not sure why the Py311 environment is failing right now, as I'm not getting any local errors.

@helrond
Copy link
Member

helrond commented Jan 30, 2025

The tests are failing for me locally for two reasons:

  1. Coverage is not finding any reporting data (because the tests aren't actually testing anything).
  2. Linting is failing.

IMO both things are fine for now - we're not going to merge this anyway until the application logic and tests are in place.

Updates gitignore for DS_Store
Deletes unnecessary file
Updates python version
Remove routes
Updates copyright year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants