Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added css to quote text properly. #843

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 8, 2025

Brief Title

now using > before any text will show separate quote, I use theme for putting color to maintain the coding standard.

Acceptance Criteria fulfillment

  • Add css to quote text propely.

Fixes #840, #675

Video/Screenshots

image
Screencast from 2025-01-11 16-24-32.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-843 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Jan 8, 2025

Fix the lint issue - Use prettier extension in your IDE and format it using prettier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these as they are unused

@thepiyush-303
Copy link
Contributor Author

@Spiral-Memory
Done.

@devanshkansagra
Copy link
Contributor

devanshkansagra commented Jan 9, 2025

Hey @Spiral-Memory, I think we can consider this fix to this issue #675 also by adding multiple blockquoting at once functionality. What do you think about?

@thepiyush-303
Copy link
Contributor Author

Hey @devanshkansagra,
Do you want me to address #675 in this PR.

@devanshkansagra
Copy link
Contributor

Yes, you can if you want to, currently I am researching upon something else, and hence this issue is not a priority at the moment, so you can address this also.

😊

@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Jan 11, 2025

hence this issue is not a priority at the moment,

okay,
can you tell the issue which are on priority so that i can also take a look on.

@devanshkansagra
Copy link
Contributor

devanshkansagra commented Jan 11, 2025

I meant that the issue I raised i.e. #675 and I am not working on that rn, this issue is kind of an inconsistency so you can fix this and add this pull request

Currently we are focusing on ui related enhancements to this project even more so you can research and work upon that too

There are no any specific issues to ui related enhancements so you can go through the project find any enhancements , if you find it and feels like it needs to get implemented then you are ready to go on 🚀

@Spiral-Memory
Copy link
Collaborator

Let me know once you add that fix here in this PR too @thepiyush-303

@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Jan 11, 2025

Already done @Spiral-Memory
My last commit address it.

@Spiral-Memory
Copy link
Collaborator

Attach a video

@thepiyush-303
Copy link
Contributor Author

Screencast.from.2025-01-11.16-24-32.mp4

@Spiral-Memory
There it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using '>' before any text doesn't quote the text separately.
3 participants