-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added css to quote text properly. #843
base: develop
Are you sure you want to change the base?
Conversation
Fix the lint issue - Use prettier extension in your IDE and format it using prettier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these as they are unused
@Spiral-Memory |
Hey @Spiral-Memory, I think we can consider this fix to this issue #675 also by adding multiple blockquoting at once functionality. What do you think about? |
Hey @devanshkansagra, |
Yes, you can if you want to, currently I am researching upon something else, and hence this issue is not a priority at the moment, so you can address this also. 😊 |
okay, |
I meant that the issue I raised i.e. #675 and I am not working on that rn, this issue is kind of an inconsistency so you can fix this and add this pull request Currently we are focusing on ui related enhancements to this project even more so you can research and work upon that too There are no any specific issues to ui related enhancements so you can go through the project find any enhancements , if you find it and feels like it needs to get implemented then you are ready to go on 🚀 |
Let me know once you add that fix here in this PR too @thepiyush-303 |
Already done @Spiral-Memory |
2ef2985
to
8f3bb40
Compare
Attach a video |
Screencast.from.2025-01-11.16-24-32.mp4@Spiral-Memory |
Brief Title
now using > before any text will show separate quote, I use theme for putting color to maintain the coding standard.
Acceptance Criteria fulfillment
Fixes #840, #675
Video/Screenshots
Screencast from 2025-01-11 16-24-32.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-843 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.