Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance Message Report modal and fix the logic of visibility of report option in toolbar #907

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 15, 2025

Brief Title

Acceptance Criteria fulfillment

  • Enhance report/modal
  • add logic for visibility
  • include css

Fixes #904

Video/Screenshots

After:

Screencast.from.2025-01-15.22-12-55.mp4

Before:

Screencast.from.2025-01-15.22-14-36.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-907 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @thepiyush-303
Thanks for the PR! It looks good to me.

Just one minor change: could you remove the display of the message here?

image

If you decide to keep the message, there are several cases to handle:

  • The markdown should render correctly.
  • After a certain message length, it should truncate and display an ellipsis.

@thepiyush-303
Copy link
Contributor Author

Hey @Spiral-Memory
I made the changes keeping RC's behavior in mind. I believe markdown will render the text perfectly. Regarding truncating the text, I will raise a new PR for it.
or:
If you want me to remove the actual message, please let me know what text should be displayed instead.

@Spiral-Memory
Copy link
Collaborator

No need to raise another PR, Pls make the change here and let me know

@thepiyush-303
Copy link
Contributor Author

instead of truncating and adding ellipsis the behaviour for long text will look like this.

Screencast.from.2025-01-28.18-56-08.mp4

is it ok @Spiral-Memory ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'Report Message' feature should hide on user's own message and enhance Report-Message Modal.
2 participants