Added color to the link messages & link present in link preview based on light and dark theme #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
|
Unable to understand the fix. Please attach a detailed video / description to help me understand. |
Currently, links are shown in black. For a better UI experience, the links should be displayed in a color different from the normal text color. When setting the color, I did not hardcode the link color; instead, I considered both light and dark modes of the theme and chose a color that looks good across all themes. Thank you for your time : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Added color to the link messages & link present in link preview based on light and dark theme
Acceptance Criteria fulfillment
Fixes #911
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-912 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.