Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete modal is now improved and Reaction emoji is added in message toolbar. #914

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 16, 2025

Brief Title

Acceptance Criteria fulfillment

  • Enhance delete modal
  • adding reaction emoji

Fixes #913

Video/Screenshots

After:

Screencast.from.2025-01-16.17-11-04.mp4

Before:

Screencast.from.2025-01-16.17-08-19.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-914 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@dhairyashiil
Copy link
Contributor

Hello @thepiyush-303,

Has the behavior changed for all messages, or only for messages with attachments like audio, video, files, and images?

For normal text messages, the current delete modal works well by displaying the message content in the modal. However, for messages with attachments, it simply displays the attachment. We can improve this by showing the filename and file description along with the attachment.

This would give the user a clear understanding of which message they are deleting.

Currently, the following texts are displayed:

  1. Are you sure?
  2. You will not be able to recover this message!
    While both are based on RC terminology, they do not provide the user with a clear idea of which message they are actually deleting.

The approach mentioned above would certainly enhance the UI and improve the user experience.

@thepiyush-303
Copy link
Contributor Author

I think we should follow Rocket's behaviour in EC also, rest will be decided by @Spiral-Memory

@Spiral-Memory
Copy link
Collaborator

Hi @thepiyush-303
Make a detailed video of your changes showing all cases

@thepiyush-303
Copy link
Contributor Author

@Spiral-Memory
it will show the same modal for all types of messages.

Screencast.from.2025-01-28.18-33-52.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Delete Modal and add reaction emoji
3 participants