fix: Code Block Overflow and Add Backdrop for Announcement Modal #940
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thepiyush-303 |
…303/EmbeddedChat into fix/WrappedCodeBlocks
Screencast.from.2025-02-02.15-18-25.mp4Done. |
Spiral-Memory
approved these changes
Feb 2, 2025
|
Good work @thepiyush-303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
include text wrapping in code-block for very large strings, Also added a backdrop and close button for Announcement modal.
Acceptance Criteria fulfillment
Fixes #939
Video/Screenshots
After:
Screencast.from.2025-01-29.22-27-16.mp4
Before:
Screencast.from.2025-01-29.22-26-23.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-940 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.