-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding mobile resposiveness #943
base: develop
Are you sure you want to change the base?
Feat: Adding mobile resposiveness #943
Conversation
Can we please have smaller Emoji box with no search in mobile |
Also, update your branch with latest changes in develop branch : It has nothing to do with playwright, why playwright changes are being reflected here |
@@ -14,6 +14,25 @@ const getAttachmentPreviewStyles = () => { | |||
width: 100%; | |||
`, | |||
|
|||
modal: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the same code is being repeated so many times, can we just make modal itself mobile responsive from ui-elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i have tried but changes are not reflecting from there
Hello @Spiral-Memory , actually, on mobile, we should have a search feature, right? Even more so than on larger screens, because mobile screens are smaller, and it's harder to find emojis there (based on my personal experience). I think we should keep the search feature on mobile as well. |
I have made the emoji picker small in my recent commit |
You are correct @dhairyashiil Not with the popups 😥 |
should i remove search bar? |
We've to look for a emoji alternative, for now, keep it smaller with search |
See how it is implemented in rocket.chat |
Anyone can work on that, as a separate PR In this PR, keep search but make the emoji popup smaller for all screens whichever looks good |
Okay, Got it. Thanks! I will look into it then |
Recording.2025-02-02.160003.mp4i have made changes in recent commit |
Great @Stpriyasharma Can you please make the requested changes too ? There is a lot of code repetition.. there is a package named ui-elements.. that have the modal component I think, you can directly make it mobile responsive Instead of repeating code everywhere modal is used |
ok @Spiral-Memory . i will make the changes |
Brief Title Adding responsiveness to mobile devices for modals
Fixes #942
Video/Screenshots
Recording.2025-02-01.120329.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-943 after approval.