Skip to content

Commit

Permalink
fix: Links inside PDFs redirecting instead of opening on the browser (#…
Browse files Browse the repository at this point in the history
…2935)


* prevent link navigation from the renderer and handle it from the main process
  • Loading branch information
jeanfbrito authored Aug 23, 2024
1 parent 43f2cd1 commit b536d81
Show file tree
Hide file tree
Showing 8 changed files with 323 additions and 22,964 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
branches:
- master

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref }}
cancel-in-progress: true

jobs:
check:
strategy:
Expand All @@ -20,12 +24,12 @@ jobs:
run: git config --global core.autocrlf false
- name: Checkout code
uses: actions/checkout@v3
- name: Setup Node 20.10.0
uses: actions/setup-node@v3
- name: Setup Node 20.14.0
uses: actions/setup-node@v4
with:
node-version: '20.10.0'
node-version: '20.14.0'
- name: Setup node_modules cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
Expand Down Expand Up @@ -56,7 +60,7 @@ jobs:
if: ${{ matrix.os == 'macos-latest' }}
run: |
brew install coreutils
gtimeout 30 ./dist/mac/Rocket.Chat.app/Contents/MacOS/Rocket.Chat || code=$?
gtimeout 30 ./dist/mac-arm64/Rocket.Chat.app/Contents/MacOS/Rocket.Chat || code=$?
if [[ $code -ne 124 && $code -ne 0 ]]; then
exit $code;
fi
Expand Down
Loading

0 comments on commit b536d81

Please sign in to comment.