Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add PDF viewer #2796

Merged
merged 11 commits into from
Feb 9, 2024
Merged

chore: Add PDF viewer #2796

merged 11 commits into from
Feb 9, 2024

Conversation

jeanfbrito
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one weird bug keeping this PR away from mergeability:

Whenever the app starts at PDF viewer (i.e. you open a PDF, closes the app immediately, reopens it) only a blank panel is visible. It feels like a common Electron's webview bug.

@jeanfbrito jeanfbrito merged commit d64e820 into master Feb 9, 2024
6 checks passed
@jeanfbrito jeanfbrito deleted the poc-builtin-pdf branch February 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants