Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional setting to start with home screen #2805

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

preeesha
Copy link

@preeesha preeesha commented Jan 6, 2024

feat: Optional setting to start with Home page

Closes #2532

This PR addresses the feature request to add an option in the setting to decide which page should be opened when the user starts the RocketChat's desktop app.

Through this PR, a new options is being added in the settings called "Always start on home page". Here's an overview:

  1. When disabled, default behaviour will be there in which when the user click on the server icon in the sidbar, it lands to the last page he/she visited in that server as stored in lastPath property.
  2. When enabled, the user will land on the home page of the server ignoring the lastPath property.

Here's a snapshot showcasing the new doAlwaysStartAtHomePage switch in config.json:
image

For context, this lastPath property is stored in the config.json. It's stored individually for each server.

Video.of.the.start.at.home.page.setting.mp4

This video showcases the working of the functionality. In this, at first, I opened the app with the "Always start at home page" setting disabled. The app lands me to the last visited page (team view) of the rocket chat community. Then I switched the setting and reopened the app & this time I got at the home page of the server instead of the last visited page.

@jeanfbrito
Copy link
Collaborator

Hey @preeesha thank you for the contribution.
Can you resolve the conflicts for us?

@preeesha
Copy link
Author

preeesha commented Feb 6, 2024

Thanks for the feedback @jeanfbrito. I'll update you within 24-48h with resolved conflicts.

@preeesha
Copy link
Author

preeesha commented Feb 6, 2024

@jeanfbrito I have resolved the conflicts. You can now proceed with reviewing the PR.

@preeesha preeesha changed the title Feat optional setting to start with home screen feat: optional setting to start with home screen Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional setting to start with Home page
2 participants