-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional setting to start with home screen #2805
Open
preeesha
wants to merge
9
commits into
RocketChat:master
Choose a base branch
from
preeesha:feat--optional-setting-to-start-with-home-screen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: optional setting to start with home screen #2805
preeesha
wants to merge
9
commits into
RocketChat:master
from
preeesha:feat--optional-setting-to-start-with-home-screen
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t home page" setting (RocketChat#2532)
…tional `lastPath` to the ServerPane (RocketChat#2532)
Hey @preeesha thank you for the contribution. |
Thanks for the feedback @jeanfbrito. I'll update you within 24-48h with resolved conflicts. |
@jeanfbrito I have resolved the conflicts. You can now proceed with reviewing the PR. |
preeesha
changed the title
Feat optional setting to start with home screen
feat: optional setting to start with home screen
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Optional setting to start with Home page
Closes #2532
This PR addresses the feature request to add an option in the setting to decide which page should be opened when the user starts the RocketChat's desktop app.
Through this PR, a new options is being added in the settings called "Always start on home page". Here's an overview:
lastPath
property.lastPath
property.Here's a snapshot showcasing the new
doAlwaysStartAtHomePage
switch inconfig.json
:For context, this
lastPath
property is stored in theconfig.json
. It's stored individually for each server.Video.of.the.start.at.home.page.setting.mp4
This video showcases the working of the functionality. In this, at first, I opened the app with the "Always start at home page" setting disabled. The app lands me to the last visited page (team view) of the rocket chat community. Then I switched the setting and reopened the app & this time I got at the home page of the server instead of the last visited page.