-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): Message details not shown in push notifications in some cases #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
force-pushed
the
fix.push-secure
branch
from
August 1, 2024 20:49
654267e
to
434d7e3
Compare
diegolmello
force-pushed
the
fix.push-secure
branch
from
August 5, 2024 17:59
96479dd
to
7342fad
Compare
This reverts commit e934bfb.
diegolmello
force-pushed
the
fix.push-secure
branch
from
August 12, 2024 20:47
abeef48
to
56f56db
Compare
This reverts commit e934bfb.
diegolmello
force-pushed
the
fix.push-secure
branch
from
August 27, 2024 18:20
56f56db
to
64de615
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
You have a new message
logic to display a single push notification without content, since it's not helpful to fill notification center with itIssue(s)
Closes #5496
Note: we've been discussing a change on rate limiter for this feature specifically, since some users might receive too many notifications in a short amount of time and that would reach the limit, making push notifications to be displayed as
You have a new message
still.Even though we do a reverse fibonacci for retry, the timing might not be enough, since the default time limit is of 5 minutes and the timeframe to fetch notification content is of 30 seconds.
How to test or reproduce
Hide message content from Apple and Google (and the Gateway, if enabled)
(aka Secured Push Notification)Here's a simple bash to help triggering those push notifications
Screenshots
Types of changes
Checklist
Further comments
CORE-85