-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade WatermelonDB to 0.27.1 #5865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
force-pushed
the
chore.upgrade-wmdb
branch
from
September 18, 2024 20:54
661e3d9
to
21e322b
Compare
diegolmello
force-pushed
the
chore.upgrade-wmdb
branch
from
September 19, 2024 21:06
bd11193
to
8953482
Compare
OtavioStasiak
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on:
iPhone 15 (iOS 17.5)
Pixel 6 (API 35)
Considerations:
The upgrade works well on both platforms, and the implementation is as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade WatermelonDB to 0.27.1, but I had to change a couple of other things in order to keep everything working properly. Most of the work was required because there was a big breaking change on WatermelonDB transitioning from Kotlin/Swift to C++.
db.action
todb.write
Issue(s)
Depends on RocketChat/Rocket.Chat#33377
How to test or reproduce
Android
iOS
Apple Watch
Screenshots
Types of changes
Checklist
Further comments
NATIVE-636