Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade WatermelonDB to 0.27.1 #5865

Merged
merged 20 commits into from
Nov 5, 2024
Merged

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 11, 2024

Proposed changes

Upgrade WatermelonDB to 0.27.1, but I had to change a couple of other things in order to keep everything working properly. Most of the work was required because there was a big breaking change on WatermelonDB transitioning from Kotlin/Swift to C++.

  • Migrate db.action to db.write
  • Remove wm patch to make Database public
  • Create a whole SQLite connectivity layer on iOS
  • Make use of android.database.sqlite.SQLiteDatabase on Android
  • Found a regression on decrypt/encrypt push notifications introduced on feat: File encryption support #5678 and fixed it
  • Adapt Apple Watch to use the new db layer

Issue(s)

Depends on RocketChat/Rocket.Chat#33377

How to test or reproduce

Android

iOS

Apple Watch

  • General usage
  • SSL client certificate
  • Update app to this PR and it should remain logged in

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-636

@diegolmello diegolmello marked this pull request as ready for review September 11, 2024 20:52
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on:

iPhone 15 (iOS 17.5)
Pixel 6 (API 35)

Considerations:

The upgrade works well on both platforms, and the implementation is as expected.

@diegolmello diegolmello merged commit a748cd6 into develop Nov 5, 2024
4 of 9 checks passed
@diegolmello diegolmello deleted the chore.upgrade-wmdb branch November 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants