feat: created thumbnail using expo-video-thumbnail #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
diegolmello
requested changes
Oct 3, 2024
| }, | ||
| playerIcon: { | ||
| position: 'absolute', | ||
| shadowColor: '#000', |
There was a problem hiding this comment.
Don't use fixed colors. Everything should come from themes.
| flex: 1 | ||
| }, | ||
| image: { | ||
| width: '100%', |
| encrypted?: boolean; | ||
| }; | ||
|
|
||
| const Thumbnail = ({ url, encrypted = false }: ThumbnailProps) => { |
There was a problem hiding this comment.
You asked my opinion about splitting Thumbnail in a separate file.
I said we should either keep on Video file (it's a small file, so it's ok) or we create a Video folder so message/Components/Attachments is organized with one file per feature.
You create Thumbnail file without a Video folder, so Attachments now have
- CollapsibleQuote (folder)
- Image (folder)
- AttachedActions.tsx
- Attachments.tsx
- Audio.tsx
- Reply.tsx
- Video.tsx
- Thumbnail.tsx (this one is only related to Video)
OtavioStasiak
force-pushed
the
improve-video-component
branch
from
4a2db10 to
073cf34
Compare
OtavioStasiak
changed the title
OtavioStasiak
force-pushed
the
improve-video-component
branch
2 times, most recently
from
233fa4c to
2df934b
Compare
diegolmello
requested changes
Oct 16, 2024
| isReply?: boolean; | ||
| msg?: string; | ||
| } | ||
| type Image = string | null; |
There was a problem hiding this comment.
Suggested change
| type Image = string | null; | |
| type TThumbnailImage = string | null; |
| fontSize: 12 | ||
| playerIcon: { | ||
| position: 'absolute', | ||
| shadowColor: themes.light.backdropColor, |
| playerIcon: { | ||
| position: 'absolute', | ||
| shadowColor: themes.light.backdropColor, | ||
| shadowOpacity: 0.3, |
OtavioStasiak
force-pushed
the
improve-video-component
branch
2 times, most recently
from
35e3dff to
300d9f2
Compare
OtavioStasiak
force-pushed
the
improve-video-component
branch
from
300d9f2 to
411d7ff
Compare
diegolmello
reviewed
Oct 22, 2024
diegolmello
approved these changes
Oct 22, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create a thumbnail to improve the video component UX.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-226
How to test or reproduce
Basic
Others
Screenshots
IOS:
Before:
videoIosBefore.mov
After:
Gravacao.de.Tela.2024-10-02.as.17.52.36.mov
Android:
Before:
android_before.webm
After:
videoPrAndroid.webm
Types of changes
Checklist
Further comments