Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Big emoji cutted #5905

Merged
merged 5 commits into from
Oct 25, 2024
Merged

regression: Big emoji cutted #5905

merged 5 commits into from
Oct 25, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Oct 8, 2024

Proposed changes

when you send a big emoji it renders cutted (as a video below) because the lineHeight was defined with 22.
I updated the emoji component looking for the newMarkdown emoji component.
Regression added on #5845.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-669

How to test or reproduce

  • Open the app;
  • Go to room;
  • Send one emoji;

Screenshots

Android

Before:

Before.mov

After:

After.mov

iOS

Before:

beforeII.mov

After:

After.II.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@diegolmello
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Otavio Stasiak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OtavioStasiak Can you fix this?

@OtavioStasiak OtavioStasiak changed the title fix: Big emoji cutted Regression: Big emoji cutted Oct 8, 2024
@OtavioStasiak OtavioStasiak changed the title Regression: Big emoji cutted regression: Big emoji cutted Oct 8, 2024
@OtavioStasiak OtavioStasiak force-pushed the fix-big-emoji-error branch 3 times, most recently from 2a3f786 to 1cda07c Compare October 15, 2024 17:28
@OtavioStasiak OtavioStasiak force-pushed the fix-big-emoji-error branch 2 times, most recently from 578f88b to a3db957 Compare October 18, 2024 02:12
@OtavioStasiak OtavioStasiak merged commit 85f6099 into develop Oct 25, 2024
4 of 9 checks passed
@OtavioStasiak OtavioStasiak deleted the fix-big-emoji-error branch October 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants