Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pinned menu returns a blank screen for certain rooms. #5934

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Oct 24, 2024

Proposed changes

MessagesView is breaking when you open pinned Messages on specific room menu.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-678

How to test or reproduce

Screenshots

Before:

Gravacao.de.Tela.2024-10-25.as.12.54.32.mov

After:

Gravacao.de.Tela.2024-10-25.as.12.55.10.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review October 24, 2024 19:18
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after videos doesn't help much, since you edited the part that it's important.
You should try to reproduce on a safe channel and show the real content.

app/containers/message/Urls.tsx Outdated Show resolved Hide resolved
@diegolmello diegolmello force-pushed the fix-messages-view-broken-error branch from 0485469 to 2646ff5 Compare October 30, 2024 16:47
@OtavioStasiak OtavioStasiak merged commit 14e0857 into develop Oct 30, 2024
4 of 9 checks passed
@OtavioStasiak OtavioStasiak deleted the fix-messages-view-broken-error branch October 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants