Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: announcement banner closing issue and visibility in hidden thread channels #6032

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

Proposed changes

This PR resolves two issues with the announcement banner.

  • Announcement banner close button was difficult to interact, which has been fixed by adding a hitSlop to improve touch responsiveness.
  • The banner was visible in both normal chats and thread channels, this has been fixed to ensure the banner is hidden in thread channels.

Issue(s)

N/A

How to test or reproduce

  1. Go to any channel which have announcement message
  2. Go to any thread in the same channel
  3. Observe the announcement message is visible at the top of the channel

Screenshots

Scenario Before After
Close button hitbox Screenshot 2024-11-30 at 3 12 17 PM Screenshot 2024-11-30 at 3 08 33 PM
Thread channel Screenshot 2024-11-30 at 3 11 19 PM Screenshot 2024-11-30 at 3 10 19 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant