Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inifite loading on two factor login #6056

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

Proposed changes

In our production version, when you try to log in to a two-factor account and click 'Cancel,' the Login button remains loading and disabled because the isFetching state is not updated. This PR fixes that issue.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-737

How to test or reproduce

  • Open the app;
  • Try to log in on account with two factor enabled.
  • click on cancel;

Screenshots

| Before | After |

| before | after |

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant