Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit room info button is flickering #6063

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Dec 16, 2024

Proposed changes

If you navigate quickly through app, sometimes the edit button does not appear. To fix this I created a ref to prevent overwriting the setHeader after loadRoom;

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-735

How to test or reproduce

  • Open the app;
  • Navigate to RoomView;
  • Navigate to RoomInfoView;
  • Click on Edit button on Header;

PS: It's a flaky behavior, so you may need to navigate back and forth a few times to reproduce the issue (on android its easier to reproduce than iOS). (Try clicking quickly to navigate to roomInfo; it helps me reproduce it with fewer attempts.);

Screenshots

Before:

WhatsApp.Video.2024-12-16.at.18.27.42.mp4

After:

WhatsApp.Video.2024-12-16.at.18.27.34.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 17, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant