Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support API_Embed setting #6070

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: Support API_Embed setting #6070

merged 1 commit into from
Dec 17, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Dec 17, 2024 •
edited by jira bot
Loading

Proposed changes

Admin > Message > Embed Link Previews

image

Issue(s)

How to test or reproduce

Screenshots

Turned on Turned off
Screenshot 2024-12-17 at 15 19 57 Screenshot 2024-12-17 at 15 20 27

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-742

@diegolmello diegolmello changed the title feat: Support API_Embed feat: Support API_Embed setting Dec 17, 2024
@diegolmello diegolmello force-pushed the feat.support-api-embed branch from 62b499b to e2e20b4 Compare December 17, 2024 18:26
@diegolmello diegolmello marked this pull request as ready for review December 17, 2024 18:28
OtavioStasiak
OtavioStasiak approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@diegolmello diegolmello merged commit 5046239 into develop Dec 17, 2024
4 of 9 checks passed
@diegolmello diegolmello deleted the feat.support-api-embed branch December 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @OtavioStasiak