Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed autocompelete issue #1300

Closed
wants to merge 2 commits into from
Closed

Conversation

vivekchavan14
Copy link

@vivekchavan14 vivekchavan14 commented Feb 25, 2024

Made minor changes in handleSelect and handleRemove to fix Autocompelete issue

changes made :

Changes in handleSelect:

  1. Added a check to ensure that currentValue is truthy before proceeding.
  2. Modified the logic to handle multiple selections and correctly update the value state based on whether it's an array or a single value.

Changes in handleRemove:

  1. Added a removedValue variable to store the value of the removed item.
  2. Utilized event.currentTarget.value to obtain the value of the removed item.
  3. Updated the filtering logic to remove the item with the corresponding value from both the selected list and the value state.

issue: #1298

Copy link

changeset-bot bot commented Feb 25, 2024

⚠️ No Changeset found

Latest commit: 580fcb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dougfabris
Copy link
Member

Hi there, thanks for the contribution! 🚀 💯

We're planning an entire replacement of all the components related to AutoComplete and all the Select components since we're focusing a lot on accessibility. Trying to maintain it became a nightmare, and because of that we're not going to accept any contributions related to these components at this time.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Feb 27, 2024
@SySagar
Copy link

SySagar commented Mar 21, 2024

hi @dougfabris since we are replacing these components which seems a breaking change to the codebase , what are we going to use as its replacement?

@dougfabris
Copy link
Member

@SySagar They are going to be replaced by brand new components with the same visual, same behavior but fully working and accessible. Because of that, we'll not receive small fixes turning the code hard to understand at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants