Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external scripts to be retrieved from personnal git repositories via HTTP(S) #231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow external scripts to be retrieved from personnal git repositories via HTTP(S) #231

wants to merge 2 commits into from

Conversation

Neonox31
Copy link

@Neonox31 Neonox31 commented Aug 1, 2017

You can now specify git+http or git+https urls as a script in the EXTERNAL_SCRIPTS env variable.
Useful when user doesn't want to publish his script on the public NPM registry.

Ex : -e EXTERNAL_SCRIPTS=hubot-pugme,hubot-help,git+https://user:token@repo/hubot-ping.git

/cc @davinkevin

…emote git HTTP(S) urls

feat(dockerfile) : improve start command to grab hubot scripts from remote git HTTP(S) urls
@Neonox31 Neonox31 changed the title Allow external scripts to be retrieived from personnal git repositories via HTTP(S) Allow external scripts to be retrieved from personnal git repositories via HTTP(S) Aug 1, 2017
@geekgonecrazy
Copy link
Contributor

I'll take a closer look. But this looks like it easily does the job.

I'm kind of thinking of at some point adding a proper nodejs script in the container so more like this can be done.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ engelgabriel
❌ WEBER Logan


WEBER Logan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants