Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to node v10.15.3 and correct issue:##318 #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to node v10.15.3 and correct issue:##318 #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Dockerfile
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
FROM node:4.8.3
FROM node:10.15.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also works with newer version

Suggested change
FROM node:10.15.3
FROM node:lts-stretch

MAINTAINER Rocket.Chat Team <[email protected]>

RUN npm install -g coffee-script yo generator-hubot && \
useradd hubot -m

USER hubot

WORKDIR /home/hubot
Expand All @@ -19,18 +18,17 @@ RUN yo hubot --owner="$BOT_OWNER" --name="$BOT_NAME" --description="$BOT_DESC" -
sed -i /redis-brain/d ./external-scripts.json && \
npm install hubot-scripts

ADD . /home/hubot/node_modules/hubot-rocketchat
ADD . /home/hubot/hubot-rocketchat

# hack added to get around owner issue: https://github.com/docker/docker/issues/6119
USER root
RUN chown hubot:hubot -R /home/hubot/node_modules/hubot-rocketchat
RUN chown hubot:hubot -R /home/hubot/hubot-rocketchat
USER hubot

RUN cd /home/hubot/node_modules/hubot-rocketchat && \
npm install && \
#coffee -c /home/hubot/node_modules/hubot-rocketchat/src/*.coffee && \
cd /home/hubot
RUN npm install ./hubot-rocketchat \
#coffee -c /home/hubot/node_modules/hubot-rocketchat/src/*.coffee &&
&& cd /home/hubot

CMD node -e "console.log(JSON.stringify('$EXTERNAL_SCRIPTS'.split(',')))" > external-scripts.json && \
npm install $(node -e "console.log('$EXTERNAL_SCRIPTS'.split(',').join(' '))") && \
bin/hubot -n $BOT_NAME -a rocketchat
bin/hubot -n $BOT_NAME -a rocketchat