-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Simulation Save and Load in JSON Files #695
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #695 +/- ##
===========================================
+ Coverage 76.06% 76.21% +0.14%
===========================================
Files 99 99
Lines 11278 11486 +208
===========================================
+ Hits 8579 8754 +175
- Misses 2699 2732 +33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)New behavior
This PR improves rocketpy encoding and introduces decoding functionalities. The way this works is:
to_dict
orfrom_dict
method, they are used to perform the (de)encoding;Breaking change
Additional information
PR #679 should be merged first.
Here are some of the steps that could be improved:
AirBrakes
+Controllers
and new classes.Some important remarks: