WIP: continuing higher-level wrappers #32
Conversation
…interfacte for magma gesvd.
|
I think now all the higher-level wrappers for linear system solvers have been finished, including gesv, gerbt, gels, posv, hesv and sysv. |
|
How about I finish the left higher wrappers for eigenvalues? Or just first consider QR LU & svd dispatching and come back to these stuff after anything else which is more important(e.g. dispatch & BB) is set up?@Roger-luo |
| return type == Float64 || type == ComplexF64 ? Float64 : Float32 | ||
| end | ||
|
|
||
| for type in magmaTypeList_real |
There was a problem hiding this comment.
you don't need to create the symbols, just use type.
| macro magmafunc_generic(function_name, str) | ||
| return Expr(:quote, Symbol(function_name, str)) | ||
| end | ||
|
|
||
| const magmaTypeTuple= (Float32, Float64, ComplexF32, ComplexF64) |
There was a problem hiding this comment.
this is sufficient. you don't need to parse strings manually.
There was a problem hiding this comment.
this is sufficient. you don't need to parse strings manually.
Ah cool. There is some improvisation made by me a long time ago for convenience. Thank you for your careful checking and improvement.
Just for polishing, e.g. fixing the getrs bug, changing into more compact forms, adding more detailed comments and e.t.c.