-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize the map type used for structured data #19
Open
Roguelazer
wants to merge
3
commits into
master
Choose a base branch
from
indexmap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roguelazer
changed the title
Map the map type used for structured data type parameter
Parameterize the map type used for structured data type parameter
Jan 18, 2021
Roguelazer
changed the title
Parameterize the map type used for structured data type parameter
Parameterize the map type used for structured data
Jan 18, 2021
Here's what hyperfine has to say for synthetic data with lots of SD fields:
And here's what it has to say for some production data with 0-3 SD items per line:
In both cases (and exclusively on this particular hardware), the fastest is HashMap + FxHash, but only by the thinnest of margins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still defaults to
BTreeMap
but allows you to use aHashMap
(or, if you pass the right feature, anIndexMap
) instead.Major breaking API changes (e.g., removal of the deref to BTreeMap, which was kind of dumb anyway).
I added a little command-line program to test different implementations and
BTreeMap
still consistently outperformsHashMap
andIndexMap
(even withfxhash
) for my test data, at least on the ARM64 MacBook Pro I'm currently typing on. Example output:This is intended to address #18