[WIP] Switch from HABTM to has_many through #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it { should exist } | ||
| it { should contain "class AdminRole < ActiveRecord::Base" } | ||
| it { should contain "has_and_belongs_to_many :admin_users, :join_table => :admin_users_admin_roles" } | ||
| it { should contain "belongs_to :admin_user" } |
There was a problem hiding this comment.
Not sure about this one... any hint?
|
This whitespace changes make this PR hard to follow... Especially when there are more commits coming. Have you checked out #181? This is another PR working on the same issue. |
|
thanks @tmaier I'm closing this one. I'll try to help in https://github.com/EppO/rolify/pull/181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first iteration, feedback are very welcome!
Original issue: https://github.com/EppO/rolify/issues/178
ToDo: