Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metascript Updates Aug 2023 #1795

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Conversation

TimRohr22
Copy link
Contributor

@TimRohr22 TimRohr22 commented Aug 4, 2023

====== INCLUDES A NEW ONE-CLICK INCLUSION: MetaScriptToolbox ======
Please add MetaScriptToolbox to the 1-click list. I have already edited the YAML

Fetch gets text object and path properties, and has checkLightLevel added to the 1-click dependencies
SelectManager gets text and path selections, as well as criteria-based inclusion/exclusion
Introducing the MetaScriptToolbox - a 1-click package that ensures users get all of the metascripts with only a single interaction with the 1-click library

Fetch gets text object and path properties.
SelectManager gets text and path selections, as well as criteria-based inclusion/exclusion
A script that packages up all of the metascripts.
approved.yaml Outdated Show resolved Hide resolved
SelectManager gets pc, npc, pt checks, as well as 'in' operation, as in:
+layer in [objects,gmlayer]
SelectManager gets a "side" criteria test
@TimRohr22
Copy link
Contributor Author

I have made both of the requested changes.
I have marked the conversations for both requested changes as "Resolved."
I have tagged the original merge-admin, matt-quests-for-tacos, to review my changes.
And I have waited 2 weeks of missed merges only to see the merge go through, but my pull request get left in the queue.

If I'm being an idiot -- and I don't discount the fact that I may very well be -- by all means tell me what I am missing or doing wrong. But on the off chance I am NOT being an idiot, then, please, by all means actually look at the pull request and merge it.

@matt-quests-for-tacos
Copy link
Contributor

@TimRohr22 Apologies for the delay, I am a new hire and still learning how our processes work here at roll 20. We have had folks out on PTO and plan to deploy this repo on Monday morning.

@TimRohr22 TimRohr22 closed this Aug 26, 2023
@TimRohr22 TimRohr22 reopened this Aug 26, 2023
@TimRohr22
Copy link
Contributor Author

I appreciate the update, @matt-quests-for-tacos ! I didn't want to seem rude, I just truly didn't know if I was being the bottleneck and there was something that I was supposed to do -- and without feedback I wasn't going to know what that was. Welcome to Roll20!

@Alicekb Alicekb merged commit 9258645 into Roll20:master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants