Spell storing fixes #1832
Merged
Spell storing fixes #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DameryDad
commented
Oct 13, 2023
DameryDad
commented
- Fixed spell-storing magic item issue with '-ADD' and '-ANY' capabilities.
- Added '-CHANGE' capability to spell-storing MIs.
- Added 'store' and 'lvl' attributes to MI data definitions to set the 'add', 'any' and 'change' status (defaults to 'none'), and to restrict the number of spell levels stored (defaults to 99).Extend
- handleAddAllPowers() to also deal with MU & PR spells at all levels, and made it asynchronous.
- Fixed checking valid spells & valid powers.
- Use stored spell row/column data to build item-specific spell lists.
- Ensure that --change-attr command rounds correctly for odd/even scores.
* Fixed spell-storing magic item issue with '-ADD' and '-ANY' capabilities. * Added '-CHANGE' capability to spell-storing MIs. * Added 'store' and 'lvl' attributes to MI data definitions to set the 'add', 'any' and 'change' status (defaults to 'none'), and to restrict the number of spell levels stored (defaults to 99).Extend * handleAddAllPowers() to also deal with MU & PR spells at all levels, and made it asynchronous. * Fixed checking valid spells & valid powers. * Use stored spell row/column data to build item-specific spell lists. * Ensure that --change-attr command rounds correctly for odd/even scores.
matt-quests-for-tacos
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.