Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Claude Sonnet 3.7 thinking via Vertex AI #1254

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

lupuletic
Copy link

@lupuletic lupuletic commented Feb 27, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

image image

Related Issues

Reviewers


Important

Adds support for Claude Sonnet 3.7 thinking via Vertex AI, including model configuration, UI updates, and tests.

  • Behavior:
    • Adds support for Claude Sonnet 3.7 thinking via Vertex AI in vertex.ts.
    • Introduces thinking configuration in VertexHandler for models with :thinking suffix.
    • Updates createMessage and completePrompt to handle thinking configuration.
  • UI:
    • Updates ApiOptions.tsx and ThinkingBudget.tsx to support thinking configuration.
    • Adds ThinkingBudget component to handle thinking token configuration.
  • Tests:
    • Adds tests for thinking functionality in vertex.test.ts.
    • Adds ApiOptions.test.tsx and ThinkingBudget.test.tsx to test UI changes.
  • Misc:
    • Updates package.json to use @anthropic-ai/vertex-sdk version ^0.7.0.
    • Adds vertexThinking to globalState.ts and api.ts.

This description was created by Ellipsis for 87b70ce. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: dd4fb6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 27, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would love @cte to take a look as well. Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2025
@lupuletic
Copy link
Author

Looks good to me, but would love @cte to take a look as well. Thanks!

sorry, should have set as draft. I am yet to push some tests and then review it myself!

@lupuletic lupuletic marked this pull request as draft February 27, 2025 22:14
lupuletic and others added 3 commits February 27, 2025 22:15
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@lupuletic lupuletic marked this pull request as ready for review February 27, 2025 22:23
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 27, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@lupuletic
Copy link
Author

should be ready to go now, whenever you have time -- thanks a lot both @mrubens and @cte !!

@cte
Copy link
Collaborator

cte commented Feb 27, 2025

🎉

@cte cte merged commit 54c6874 into RooVetGit:main Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants