Prettier thinking blocks #1256
Merged
Prettier thinking blocks #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 360e47d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
mrubens
approved these changes
Feb 28, 2025
cte
force-pushed
the
cte/pretty-thinking
branch
from
bacbd57 to
b3fd1a2
Compare
| }, [elapsed]) | ||
|
|
||
| // Process the transition queue. | ||
| const processNextTransition = useCallback(() => { |
There was a problem hiding this comment.
The recursive setTimeout in processNextTransition has no cleanup. Consider storing timeout IDs and cleaning up on unmount to avoid leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
thinking-4k.mp4
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Refactor
ReasoningBlockfor improved UI transitions and elapsed time display, with updates inChatRowand CSS for consistency.ReasoningBlockto handle transitions and display elapsed time usingCounterClockwiseClockIcon.ChatRow.tsxto use the refactoredReasoningBlock.--color-vscode-editorGroup-bordertoindex.cssfor consistent border styling.ReasoningBlock.tsxfor better UI consistency.This description was created by
for 360e47d. It will automatically update as commits are pushed.