ExtensionStateContext does not correctly merge state #1322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We weren't correctly merging the extension state when receiving "state" updates in the webview from the extension. This was a pretty subtle bug, but the blank initial model id in the
WelcomeView
exposed it nicely.Implementation
Screenshots
How to Test
Get in Touch
Important
Fixes state merging in
ExtensionStateContext
by introducingmergeExtensionState
and updates tests accordingly.mergeExtensionState
inExtensionStateContext.tsx
to correctly mergeExtensionState
objects.ExtensionStateContextProvider
to usemergeExtensionState
for handling "state" messages.mergeExtensionState
inExtensionStateContext.test.tsx
to verify correct merging ofapiConfiguration
properties.This description was created by
for e201ee8. It will automatically update as commits are pushed.